Skip to content

test(react-query/useSuspenseQuery): remove unnecessary 'act' from background refetch, 'refetchInterval', and post-unmount assertions#10212

Open
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/react-query-useSuspenseQuery-remove-unnecessary-act
Open

test(react-query/useSuspenseQuery): remove unnecessary 'act' from background refetch, 'refetchInterval', and post-unmount assertions#10212
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/react-query-useSuspenseQuery-remove-unnecessary-act

Conversation

@sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Mar 2, 2026 •
edited by coderabbitai bot
Loading

🎯 Changes

Remove 4 unnecessary act wrappers from useSuspenseQuery.test.tsx where suspend resolution is not involved:

  • Line 203: Post-unmount timer — component already unmounted, only checking observer count
  • Line 814: Background refetch via refetch() — component already has data displayed, refetch triggers status change without suspend
  • Lines 925, 927: refetchInterval background refetch — data updates (count: 1 → 2 → 3) without suspend

act is only needed for suspend → resolve or suspend → error transitions. Background refetches and post-unmount assertions don't require act.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Tests
    • Optimized test execution flow for asynchronous timer operations.

@sukvvon
test(react-query/useSuspenseQuery): remove unnecessary 'act' from bac…
2dd5aae 
…kground refetch, 'refetchInterval', and post-unmount assertions
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2026

⚠️ No Changeset found

Latest commit: 2dd5aae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a59b2d and 2dd5aae.

📒 Files selected for processing (1)
  • packages/react-query/src/__tests__/useSuspenseQuery.test.tsx
📝 Walkthrough

Walkthrough

This PR removes act() wrappers from timer advancement calls in the useSuspenseQuery test suite. Four instances of advanceTimersByTimeAsync() are now invoked directly without surrounding act wrappers, changing how test synchronization and effect flushing occurs in those specific test scenarios.

Changes

Cohort / File(s) Summary
Suspense Query Test Updates
packages/react-query/src/__tests__/useSuspenseQuery.test.tsx		 Removed act() wrappers from four advanceTimersByTimeAsync() calls across Suspense toggle, refetch error, and post-unmount assertion tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • TanStack/query#10090 — Both PRs modify test timer handling in react-query; this PR removes act wrappers while the related PR migrates to fake timers and adopts advanceTimersByTimeAsync.

Suggested labels

package: react-query

Suggested reviewers

  • TkDodo
  • manudeli

Poem

🐰 Timer advances dance so free,
No act() wrappers—just let them be!
Effects and flushes, state updates flow,
Simpler tests with less to know. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: removing unnecessary 'act' wrappers from three test scenarios in useSuspenseQuery tests.
Description check ✅ Passed The description is complete with all required sections, clear rationale for the changes, and proper checklist completion indicating local testing and docs-only impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 2, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2dd5aae

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 43s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-02 16:03:49 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 2, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10212

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10212

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10212

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10212

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10212

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10212

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10212

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10212

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10212

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10212

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10212

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10212

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10212

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10212

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10212

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10212

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10212

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10212

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10212

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10212

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10212

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10212

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10212

commit: f9015ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: react-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sukvvon